Add filter to allow disabling an OSGi capability requirement#1073
Open
laeubi wants to merge 4 commits into
Open
Add filter to allow disabling an OSGi capability requirement#1073laeubi wants to merge 4 commits into
laeubi wants to merge 4 commits into
Conversation
merks
approved these changes
May 18, 2026
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
Seems like a good idea. Some tiny little suggestions.
Test Results12 files - 6 12 suites - 6 0s ⏱️ - 28m 42s Results for commit 0cfd7b9. ± Comparison against base commit e3b8d67. This pull request removes 2143 tests.♻️ This comment has been updated with latest results. |
…2/tests/publisher/actions/BundlesActionRequireCapabilityFilterTest.java Co-authored-by: Ed Merks <Ed.Merks@gmail.com>
…se/equinox/p2/publisher/eclipse/BundlesAction.java Co-authored-by: Ed Merks <Ed.Merks@gmail.com>
…2/tests/publisher/actions/BundlesActionRequireCapabilityFilterTest.java Co-authored-by: Ed Merks <Ed.Merks@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to use generic require capability in builds that otherwise would create a cyclic dependency issue.
This is similar to what SWT does here:
https://github.com/eclipse-platform/eclipse.platform.swt/blob/7f9089ed7daaf630970fea7fa5bdb18cfba5cdcb/bundles/org.eclipse.swt/META-INF/p2.inf
!(org.eclipse.swt.buildtime=true)filter property that we then set here https://github.com/eclipse-platform/eclipse.platform.swt/blob/7f9089ed7daaf630970fea7fa5bdb18cfba5cdcb/bundles/org.eclipse.swt/pom.xml#L39-L41 to disable this only for building the host.This change has to actually happen at Tycho (where we should have a integration test), but for consistency and to gather some agreement first I opened it here.